Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriber-dummy): make crate version valid by adding the patch part #1058

Merged

Conversation

RRRadicalEdward
Copy link
Contributor

@RRRadicalEdward RRRadicalEdward commented Oct 15, 2024

Because of this, I can't use DevolutionsGateway as a git dependency. cargo gives a parsing error
image

@RRRadicalEdward
Copy link
Contributor Author

RRRadicalEdward commented Oct 15, 2024

@CBenoit please have a look (I can't set you to be a reviewer)

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I modified the version to be 0.0.0 since there is no plan for publishing on crates.io

@CBenoit CBenoit enabled auto-merge (squash) October 16, 2024 09:52
@CBenoit
Copy link
Member

CBenoit commented Oct 17, 2024

@RRRadicalEdward Our CI is not happy with the repository being a fork, I’ll look into this. Sorry for the delay. In the meantime, you can point the dependency to your fork to test compilation.

@CBenoit CBenoit merged commit fe0f9a6 into Devolutions:master Oct 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants